Skip to content

🐛Fix possible race condition in distributed semaphore initialization #8411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

🐛Fix possible race condition in distributed semaphore initialization #8411

merged 2 commits into from
Sep 23, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 23, 2025

What do these changes do?

#8401 introduced a FAIR queued semaphore.
Tests running in master CI revealed a race condition on the initialization phase of the semaphore. This PR fixes this definitely.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Cheops milestone Sep 23, 2025
@sanderegg sanderegg self-assigned this Sep 23, 2025
@sanderegg sanderegg requested a review from pcrespov as a code owner September 23, 2025 22:02
@sanderegg sanderegg added the a:services-library issues on packages/service-libs label Sep 23, 2025
@codecov
Copy link

codecov bot commented Sep 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.78%. Comparing base (a210b2d) to head (d1b5f03).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8411      +/-   ##
==========================================
- Coverage   89.57%   87.78%   -1.80%     
==========================================
  Files        1750     1523     -227     
  Lines       68604    63332    -5272     
  Branches      837      679     -158     
==========================================
- Hits        61450    55593    -5857     
- Misses       6931     7503     +572     
- Partials      223      236      +13
Flag Coverage Δ
integrationtests 63.93% <ø> (-0.09%) ⬇️
unittests 86.19% <100.00%> (-1.92%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.56% <100.00%> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.99% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 91.96% <ø> (ø)
autoscaling 95.74% <ø> (ø)
catalog 92.36% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.38% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 90.88% <ø> (-0.09%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.43% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.62% <ø> (ø)
resource_usage_tracker 91.71% <ø> (-0.54%) ⬇️
storage 86.53% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.02% <ø> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a210b2d...d1b5f03. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg merged commit fba8218 into ITISFoundation:master Sep 23, 2025
2 checks passed
@sanderegg sanderegg deleted the semaphore/fix-flaky-test branch September 23, 2025 22:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 23, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for d1b5f03.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 24, 2025
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@wvangeit wvangeit Awaiting requested review from wvangeit

@GitHK GitHK Awaiting requested review from GitHK

@JavierGOrdonnez JavierGOrdonnez Awaiting requested review from JavierGOrdonnez

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

a:services-library issues on packages/service-libs

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

1 participant

@sanderegg